Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

show correct data in CB.setMatrixData when showNA=FALSE #125

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from

Conversation

apomatix
Copy link

@apomatix apomatix commented Mar 12, 2019

I write about this in Issue #123. Please read what I wrote there.

@codecov-io
Copy link

codecov-io commented Mar 12, 2019

Codecov Report

Merging #125 into develop will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff            @@
##           develop     #125   +/-   ##
========================================
  Coverage    84.74%   84.74%           
========================================
  Files           25       25           
  Lines          983      983           
========================================
  Hits           833      833           
  Misses         150      150

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d570b7f...63918e7. Read the comment docs.

@apomatix
Copy link
Author

@colearendt please accept my pull request.

@apomatix
Copy link
Author

Hi @colearendt

Can you please tell me if you have a chance to look at my PR and if you have any questions?

I provide a complete analysis of the bug I found, including a minimal reproducible example, diagnosis of the problem, a fix for the bug, a test, bump version. The new version is passing checks. I think you should accept this awesome pull request.

@colearendt
Copy link
Owner

@apomatix Thanks for the PR and for the thorough writeup. I have not had a chance to review yet, but definitely plan to do so! When I get a chance to review, I'll let you know if I have any questions / suggestions, etc.

@apomatix
Copy link
Author

@colearendt pinging you again, hope you can accept my PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants