fix: add configurable terminal font family - #116
Closed
BearHuddleston wants to merge 4 commits into
Closed
Conversation
BearHuddleston
marked this pull request as ready for review
April 8, 2026 03:04
Contributor
Author
|
@yiliushenburke Ready 🐻 |
# Conflicts: # collab-electron/packages/components/src/Terminal/TerminalTab.tsx # collab-electron/packages/shared/src/terminal-font.test.ts # collab-electron/packages/shared/src/terminal-font.ts # collab-electron/src/windows/settings/src/App.tsx
BearHuddleston
force-pushed
the
BearHuddleston/wslg-terminal-fonts
branch
from
April 8, 2026 03:30
66c963c to
bddfee7
Compare
Contributor
|
looks pretty good to me |
Contributor
|
Thx @BearHuddleston (and @theblondealex)! Taking a look shortly |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Make the embedded terminal font configurable from Settings so users can explicitly choose a Nerd Font such as
FiraCode Nerd Font Mono, while keeping fallback composition and updating open terminals when the preference changes.Why
The terminal still defaulted to a generic Menlo/Monaco/Courier stack, so installing a Nerd Font alone was not enough to make icon-heavy TUIs render with the intended font. Instead of auto-picking a detected font, this change makes the preference explicit and user-controlled.
What changed
terminalFontFamilyfrom prefs and react topref:changedso open terminals pick up the new font immediately.onPrefChangedin the universal preload API.Terminal font familyfield in Settings with common suggestions and reset behavior.Validation
bun test packages/shared/src/terminal-font.test.tsbun x tsc --noEmit --pretty falseNotes
FiraCode Nerd Font Monoare expanded with the built-in fallback stack automatically.Video
2026-04-07.21-43-57.mp4