Issue 621 - Remove unnecessary adapter #622
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@frapell FYI |
CHANGES.rst
Outdated
| @@ -6,7 +6,8 @@ There's a frood who really knows where his towel is. | |||
| 1.1b2 (unreleased) | |||
| ^^^^^^^^^^^^^^^^^^ | |||
|
|
|||
| - Nothing changed yet. | |||
| - Remove unnecessary adapter (closes`621`_). | |||
There was a problem hiding this comment.
@rodfersou I think this reference is unnecessary; also, please write a better changelog entry.
this will need an extra pinning on plone.app.layout on setup.py.
rodfersou
force-pushed
the
issue_621
branch
3 times, most recently
from
66fba17
to
9309c5d
Compare
|
@rodfersou we need a rebase and a pinning here. |
|
@hvelarde done |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #621
This change removes compatibility with Plone 4.2