Skip to content

Update gha, test Python3.12 for Plone 6.0.10+ #155

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 10 commits into from
Apr 16, 2024
Merged

Conversation

fredvd
Copy link
Member

@fredvd fredvd commented Apr 14, 2024

No description provided.

@fredvd fredvd changed the title Update gha Update gha, test Python3.12 for Plone 6.0.10+ Apr 14, 2024
@fredvd
Copy link
Member Author

fredvd commented Apr 15, 2024

@mauritsvanrees @petschki I tried to add Python 3.12 support here, but I cannot solve the test failures. It has something to do with setuptools not being installed by default anymore and an old version is gettting set up in the test environment. Then the test fails with ImpImporter no longer being available.

@mauritsvanrees
Copy link
Member

I pinned setuptools in main.yml to the same version that you did in mx.ini and luckily that solves it.

@mauritsvanrees
Copy link
Member

BTW, the fix seems to be in setuptools 66.1 already.

@mauritsvanrees mauritsvanrees merged commit 98323e4 into master Apr 16, 2024
5 checks passed
@mauritsvanrees mauritsvanrees deleted the update_gha branch April 16, 2024 09:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants