Use setup-plone branch maurits-fixes. #156
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is for testing plone/setup-plone#4 Not sure if this is the correct spelling. On that branch we use the setuptools version that is pinned in the constraints of Plone, which should be fine for both 6.0 and 6.1, also on Python 3.12.
|
I have marked it as draft, as this change should not be merged. |
fredvd
approved these changes
Apr 16, 2024
There was a problem hiding this comment.
LGTM, but as you mentioned this is just to test an update to setup-plone.
I'm not such a fan of setup-plone anymore: the problem with it is that we are again running pip install twice on possibly different contraints, one from core plone in setup-plone and then again your own project pinnings. This could cause problems with downpinning/different pins and it is also inefficient.
I put this somewhere in a ticket on a project recently, but I forgot where. Just calling setup-python directly in your project GHA and then do the 'full' pip install is 5-8 lines extra and that's about what setup-plone does.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is for testing plone/setup-plone#4
Not sure if this is the correct spelling.
On that branch we use the setuptools version that is pinned in the constraints of Plone, which should be fine for both 6.0 and 6.1, also on Python 3.12.