(fix+feat): If a language doesn't have a value for taxonomy set the default language value #172
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dobri1408
changed the title
ale-rt
reviewed
Feb 20, 2025
src/collective/taxonomy/jsonimpl.py
Outdated
Comment on lines
144
to
146
| data = json.loads(self.request.get("BODY", "")) | ||
| taxonomy = queryUtility(ITaxonomy, name=data["taxonomy"]) | ||
| default_language = taxonomy.default_language |
There was a problem hiding this comment.
This code looks very brittle...
Imagine:
self.request.get("BODY", "")evaluates to "".
Then you will have:
>>> json.loads("")
Traceback (most recent call last):
...
raise JSONDecodeError("Expecting value", s, err.value) from None
json.decoder.JSONDecodeError: Expecting value: line 1 column 1 (char 0)but every line that follow can easily fail if the request body is not exactly what you expect.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We've identified a bug in the language translation of taxonomies. When a value is missing for a specific language, the system incorrectly assigns PATH_SEPARATOR + "" = id. This causes the taxonomy to default to a single value, matching the last term of the default language. Instead, if no value is provided for a given language, the correct behavior should be to use the default language value.