WIP: fixed hardcoded enclosure on AudioFeedItem#63
Open
pigeonflight wants to merge 1 commit intomasterfrom
Open
WIP: fixed hardcoded enclosure on AudioFeedItem#63pigeonflight wants to merge 1 commit intomasterfrom
pigeonflight wants to merge 1 commit intomasterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
has_enclosureis hardcoded for AudioFeedItem but not for VideoFeedItem.see:
https://github.com/collective/wildcard.media/blob/master/wildcard/media/browser/syndication.py#L11-L13
This breaks social tags on plone.app.layout 2.5.x on In Plone 5.0.x.
Resulting in an
"error while rendering plone.htmlhead.socialtags" on Plone 5.0.x
This pull request fixes the issue by providing a proper
has_enclosurefor AudioFeedItemI've marked it WIP as I need to add some tests etc...