Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add configuration option for tile bbox #1286

Merged

Conversation

matkoniecz
Copy link
Contributor

partially addresses #1284

tested with "bbox": [-13821, 6707971, -7886, 6711363]

screen06

@matkoniecz
Copy link
Contributor Author

I considered also more verbose config format, with values like tile_bbox_epsg_3857_south_limit, tile_bbox_epsg_3857_north_limit, tile_bbox_epsg_3857_east_limit, tile_bbox_epsg_3857_west_limit

@matkoniecz matkoniecz force-pushed the feature/configure-tile-coverage branch from e9f02b4 to 5c24014 Compare December 18, 2023 13:54
@matkoniecz
Copy link
Contributor Author

@Ruben1729 review is welcome!

@matkoniecz matkoniecz merged commit 90044bd into colouring-cities:master Dec 23, 2023
2 checks passed
@matkoniecz matkoniecz deleted the feature/configure-tile-coverage branch December 23, 2023 11:55
@KoaCWells
Copy link

@matkoniecz May I ask what the intention of the bounding box is? From my impression so far, each Colouring City project should only have building polygons that belong to their corresponding city so I am having a bit of trouble understanding why it is used. Is there some sort of benefit in terms of performance or necessity? We were able to remove the bounding box entirely from Colouring Montreal without any issues so far. Thanks in advance for your feedback!

@matkoniecz
Copy link
Contributor Author

@KoaCWells Without this bounding box panning across world will create empty tiles that will be then cached.

Maybe extra complexity added by this option and small space saved is making it not worth it? It may be useful to check how much space is saved in the best case (someone dragging map across entire world, at every zoom level).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants