Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Newcastle University logo #1360

Merged
merged 1 commit into from
Apr 5, 2024

Conversation

matkoniecz
Copy link
Contributor

@mdsimpson42
Copy link
Contributor

If we're removing Newcastle from Core, should we remove some of the other logos too? It might make sense to remove all of them except for the CCRP and Turing logos? (They're all London/Britain-specific apart from those two)

Are we keeping them on Colouring Britain?

Thoughts @polly64?

@matkoniecz
Copy link
Contributor Author

matkoniecz commented Mar 28, 2024

colouring-cities#318 (comment) has

Hide Newcastle university logo - university logos are only included where free resources and/or research time have been contributed by a university

and

Maybe all logos should be removed in upstream (colouring-core) repository and it should be maintained only in colouring-britain?

Maybe it should be moved to config to enable other cities/countries to easily list their partners?

@polly64
Copy link
Contributor

polly64 commented Mar 28, 2024

@mdsimpson42 don't worry and let's leave as it is and redo when we've got first tranche win uni's on board. I just want to remove Newcastle as its not contributing help in kind and the logos are a way of incentivising universities to contribute. Obviously Newcastle and your are on Colouring Britain manual map. But I will recontact SB now and see if they want polygons for Newcastle added. We need to keep OS and the GLA on because they are partners in the OS licence that allows us to test OSMM. Loughborough, University College London need to go on - with , University of Birmingham, Exeter, Cambridge and others added as they come on board adding data - if they want to give logos.

We probably need to have a line separating current and previous funders/partners saying 'Support has also kindly been provided by: Historic England, Innovate UK and The Geospatial Commission, The MacArthur Foundation, should stay as they are prototype funders. My old computer is dead and had logo file on it though alll these need to be reasked for . I will try and retrieve.

@mdsimpson42 mdsimpson42 merged commit 190cf22 into colouring-cities:master Apr 5, 2024
2 checks passed
@matkoniecz matkoniecz deleted the fix/newcastle branch April 5, 2024 17:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants