Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wider definition of source coming from qualified people. #1444

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

matkoniecz
Copy link
Contributor

some experts are not professionals

SELECT column_name FROM information_schema.columns WHERE table_name = 'buildings' and column_name LIKE '%source_type';

was used to find columns where format changed

size_storeys_source_type
size_height_apex_source_type
size_height_eaves_source_type
size_floor_area_source_type
size_width_frontage_source_type
landowner_source_type
designers_source_type
builder_source_type
extension_source_type
size_far_ratio_source_type
size_plot_area_total_source_type
size_parcel_geometry_source_type
context_garden_source_type
context_street_width_source_type
context_pavement_width_source_type
context_green_space_distance_source_type
context_tree_distance_source_type
context_street_geometry_source_type
age_cladding_date_source_type
age_extension_date_source_type
age_retrofit_date_source_type
energy_solar_source_type
energy_green_roof_source_type
planning_crowdsourced_site_completion_source_type
date_source_type
planning_scientific_interest_source_type
typology_classification_source_type
typology_style_period_source_type
typology_dynamic_classification_source_type
typology_original_use_source_type
building_attachment_source_type
construction_structural_system_source_type
construction_foundation_source_type
construction_roof_shape_source_type
construction_irregularities_source_type
construction_roof_covering_source_type
construction_decorative_feature_source_type
construction_internal_wall_source_type
construction_external_wall_source_type
construction_ground_floor_source_type
construction_core_material_source_type
location_subdivisions_source_type
developer_source_type
designer_source_type
community_public_ownership_source_type
extension_developer_source_type
extension_designers_source_type
extension_builder_source_type
sust_breeam_rating_source_type
sust_energy_rating_source_type
building_client_source_type
extension_client_source_type

these columns should be edited, either by a database migration of by an automated script - not sure yet which is better

@matkoniecz matkoniecz marked this pull request as draft November 25, 2024 10:28
@matkoniecz
Copy link
Contributor Author

for this and #1445 I decided that

  • making a bot edit explicitly changing value in history is better (more clear history, consistent data and history)
  • but it may be easily missed by downstream platforms and is more annoying to run

therefore I will add database migrations AND a bot edit

I will run bot edit on Colouring Britain, other platforms are free to use it when upgrading

database migration also will be listed so people just merging commits and running database migrations will not make part of their data invisible

(this change is extra annoying due to huge number of affected fields, it still needs to be verified whether name-based search caught all of them)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant