Remove redundant code and fix phpDoc #55
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1. Method `rawQuery()` can't return false because method `error()` can't return any result (it throws an exception or triggers error); 2. As `rawQuery()` always returns truthy value `if ($res = $this->rawQuery())...` construction is no sense; 3. `mysqli_fetch_array()` can't return FALSE. It returns neither array or NULL; 4. As `fetch()` returns array or NULL `getRow()` also returns array or NULL; 5. `getOne()` doesn't free resultset if the query have empty result (not sure if it's bad, but I think it might be better if we clean all resources after method calling).
|
It seems point 5 (about |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
rawQuery()can't return false because methoderror()can't return any result (it throws an exception or triggers error);rawQuery()always returns truthy valueif ($res = $this->rawQuery())...construction is no sense;mysqli_fetch_array()can't return FALSE. It returns array or NULL;fetch()returns array or NULLgetRow()also returns array or NULL;getOne()doesn't free resultset if the query have empty result (not sure if it's bad, but I think it might be better if we clean all resources after method calling).