Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Enable remaining Scala Native tests #274

Open
wants to merge 6 commits into
base: main
Choose a base branch
from
Open

Conversation

lihaoyi
Copy link
Member

@lihaoyi lihaoyi commented May 30, 2024

These tests currently fail on Scala-Native, but pass on Scala-JVM, and do not have a reason they should not pass on Scala-Native as well

@lihaoyi
Copy link
Member Author

lihaoyi commented May 30, 2024

@WojciechMazur any chance I could trouble you to look into these? The failures should be on the Scala-Native side of things

@LeeTibbert
Copy link

lihaoyi,

Thank you for the time you and others have spent adding support for Scala Native.

@WojciechMazur asked me to look at the macOS & Linux process related errors. I guess
that I did not dust my fingerprints off that code carefully enough.

Through code inspection I have already discovered & PR'd one bug. isAlive() could incorrectly
returning "true" after a process had really exited. Oops!

My next step is to run the reproducer which Wojciech has created against the most recently
released Scala Native.

Then I might see if I can run it against a private build of Scala Native containing my fix from
today. Who knows, sometimes magic happens.

Realistically, I think I will have to do some minimal private design studies where a pipe gets
broken whilst one end is in waitfor. (I suspect the actually call is a waitfor(timeout) but
that is suspicion, not evidence.)

I'll keep you posted, but it is probably doing to be multiple days between updates.

Does this fit in with your plan?

@lihaoyi
Copy link
Member Author

lihaoyi commented Jun 5, 2024

Yes please take your time investigating, take as long as you need

@LeeTibbert
Copy link

I've found an additional bug in Scala Native 0.5.4-SNAPSHOT.

With a trial fix for that bug and the isAlive fix already in that version, the reproducer
which Wojciech posted in Scala Native Issues works fine for me.

I hope to create a PR for Scala Native in the next day or so.

@LeeTibbert
Copy link

lolgab, Thank you for updating to Scala Native 0.5.4.

It looks like some of the tests are failing, linux & macOS. Is it evident to you that something is going
wrong because of SN? That is, that something didn't get fixed and requires additional attention?

You have more experience and knowledge looking at these CI log files than I do.

Thank you for your time.

@lihaoyi
Copy link
Member Author

lihaoyi commented Jun 28, 2024

@LeeTibbert looks like its getting stuck and timing out

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants