Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: ensure casting to torch.uint8 #3555

Closed

Conversation

dnswd
Copy link

@dnswd dnswd commented May 24, 2024

Fixes #3539

@dnswd dnswd requested a review from comfyanonymous as a code owner May 24, 2024 06:41
@comfyanonymous
Copy link
Owner

if you do:

        latents_ubyte = latents_ubyte.to(device="cpu", dtype=torch.uint8, non_blocking=comfy.model_management.device_supports_non_blocking(latent_image.device))
        latents_ubyte = latents_ubyte.to(dtype=torch.uint8)

does it also work?

@dnswd
Copy link
Author

dnswd commented May 24, 2024

I tried it again and the previews are just dots of rgb, but it doesn't seem to have any error

image

@dnswd
Copy link
Author

dnswd commented May 29, 2024

Closed in favor of #3583

@dnswd dnswd closed this May 29, 2024
@dnswd dnswd deleted the fix-ensure-torch-unit8-casting branch May 29, 2024 03:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cannot handle this data type: (1, 1, 3), <f4
2 participants