Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make extension method types optional #3577

Closed

Conversation

christian-byrne
Copy link

Updated the methods in the ComfyExtension interface to be optional. Currently typescript is requiring all of them when declaring an extension.

@mcmonkey4eva mcmonkey4eva added Frontend Issue relates to the frontend UI (litegraph). Good PR This PR looks good to go, it needs comfy's final review. labels Jun 28, 2024
@mcmonkey4eva
Copy link
Collaborator

looks like this fix was slipped into another recent PR 90aebb6#diff-9d5af490e3b560e2aae57cedc9e3722f0aac20e9e4bdef7d8f427d7dcc409040L13

@mcmonkey4eva mcmonkey4eva removed the Good PR This PR looks good to go, it needs comfy's final review. label Jun 28, 2024
@christian-byrne christian-byrne deleted the extension-types branch June 29, 2024 01:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Frontend Issue relates to the frontend UI (litegraph).
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants