[Developer Experience] Add node typing #5676
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Test is failing, should we drop support for python 3.8 or will you fix it? |
huchenlei
commented
Nov 20, 2024
| @@ -28,7 +28,7 @@ jobs: | |||
| - name: Start ComfyUI server | |||
| run: | | |||
| python main.py --cpu 2>&1 | tee console_output.log & | |||
| wait-for-it --service 127.0.0.1:8188 -t 600 | |||
| wait-for-it --service 127.0.0.1:8188 -t 30 | |||
There was a problem hiding this comment.
Reduce wait time from 10min to 30s to make the test fail faster.
Fixed |
|
@comfyanonymous Ping on review. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Upstreams https://github.com/webfiltered/comfy_typing
This PR adds typing support for ComfyUI nodes so that node developers can have type hints from the IDE.
Some other side effects:
CLIPTextEncodeas an example