-
Notifications
You must be signed in to change notification settings - Fork 6.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Convert latents_ubyte
to 8-bit unsigned int before converting to CPU
#6300
base: master
Are you sure you want to change the base?
Conversation
it indeed resolves #3539. This has been an on-going issue for AMD device users and needs to be addressed ASAP. |
can you make this only apply on directml? |
A code snippet to help make the directml check: in comfy.model_management.py, there is a variable called
|
I was actually going to suggest this in the morning after sleeping on it, but I see you beat me to it. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry, I'm new here and I don't understand. I'm happy to update the PR, but I'm not understanding where to insert the provided snippet. Is it just this? (plus the import)
@shenanigansd If you're stuck making that change, I can make a contribution to your PR so that we can get this change through. |
Sorry, I just got busy at work and haven't had a chance to circle back yet. I think I've made the requested changes correctly now in 79c526f. If I messed up, please go ahead and make the correct updates @Kosinkadink. |
No worries, just wanted to make sure this PR doesn't go stale given a lot of AMD peeps may be impacted by this. The change looks good to me, I don't have an AMD gpu at the moment to test it on, but assuming this works on your machine, I think this can get merged in very soon. |
Hello, not sure if this is the best solution, but looks like it fixes the issue described in #3539 for most people, me included, so I'll go ahead and submit this PR.
Fixes #3539