[optimization] Reduce RAM/VRAM traffic in graph.py by grouping nodes to execute by model type as well #9897
+129
−59
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[update for current ComfyUI version] Grouping Models during execution to reduce the amount of RAM/VRAM passing, speeding up execution of graphs containing the same model.
|
Hey, to demonstrate the execution optimization, would you be able to do some comparisons between this PR and current code by using comfyui-benchmark? This will help a ton in the review process. Thanks! edit: Basically, you'd just need to install the nodepack, and then it will automatically put .json benchmark data into output/benchmarks directory that you can submit here. You don't need to worry about visualizing the data yourself, although if you read the README of comfyui-benchmark you are free to do so! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[update for current ComfyUI version] Grouping Models during execution to reduce the amount of RAM/VRAM passing, speeding up execution of graphs containing the same model.