Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add PolicyMiddleware #521

Merged
merged 6 commits into from
Dec 4, 2023
Merged

add PolicyMiddleware #521

merged 6 commits into from
Dec 4, 2023

Conversation

jenschude
Copy link
Contributor

  • Changeset added

Features

Fixes

Breaking changes

- add new PolicyMiddleware which is able to combine different FailSafe policies. Builder supports Bulkhead, Timeout and Retry directly
Copy link

codecov bot commented Nov 21, 2023

Codecov Report

Attention: 213 lines in your changes are missing coverage. Please review.

Comparison is base (5dcb880) 10.21% compared to head (549c1fc) 10.28%.

Files Patch % Lines
...ommercetools/api/defaultconfig/ApiRootBuilder.java 1.49% 66 Missing ⚠️
...in/java/io/vrap/rmf/base/client/ClientBuilder.java 5.88% 64 Missing ⚠️
.../vrap/rmf/base/client/http/RetryPolicyBuilder.java 47.82% 47 Missing and 1 partial ⚠️
...va/io/vrap/rmf/base/client/http/PolicyBuilder.java 40.00% 24 Missing ⚠️
...io/vrap/rmf/base/client/http/PolicyMiddleware.java 25.00% 3 Missing ⚠️
...client/http/FailsafeConcurrencyBuilderOptions.java 0.00% 2 Missing ⚠️
...ase/client/http/FailsafeTimeoutBuilderOptions.java 0.00% 2 Missing ⚠️
...s/history/defaultconfig/HistoryApiRootBuilder.java 0.00% 1 Missing ⚠️
.../importapi/defaultconfig/ImportApiRootBuilder.java 0.00% 1 Missing ⚠️
...mmercetools/ml/defaultconfig/MLApiRootBuilder.java 0.00% 1 Missing ⚠️
... and 1 more
Additional details and impacted files
@@             Coverage Diff              @@
##               main     #521      +/-   ##
============================================
+ Coverage     10.21%   10.28%   +0.07%     
- Complexity     1659     1681      +22     
============================================
  Files          5980     5986       +6     
  Lines         56158    56388     +230     
  Branches        255      260       +5     
============================================
+ Hits           5734     5798      +64     
- Misses        50258    50423     +165     
- Partials        166      167       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jenschude jenschude merged commit 6146fe8 into main Dec 4, 2023
9 checks passed
@jenschude jenschude deleted the policy_middleware branch December 4, 2023 11:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant