Merge pull request #11 from commercetools/fix-full-ingestion

Fix missing store key in full-ingestion module
commercetools · Sep 14, 2023 · 54b3b1e · 54b3b1e
2 parents 5ea830f + aea1a61
commit 54b3b1e
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 6 deletions.
diff --git a/full-ingestion/src/clients/query.client.js b/full-ingestion/src/clients/query.client.js
@@ -10,10 +10,10 @@ const queryArgs = {
   expand: ['productSelection', 'taxCategory', 'productType', 'categories[*]'],
 };
 
-export async function getProductProjectionInStoreById(productId) {
+export async function getProductProjectionInStoreById(storeKey, productId) {
   return await createApiRoot()
     .inStoreKeyWithStoreKeyValue({
-      storeKey: Buffer.from(process.env.CTP_STORE_KEY).toString(),
+      storeKey: Buffer.from(storeKey).toString(),
     })
     .productProjections()
     .withId({
@@ -24,7 +24,7 @@ export async function getProductProjectionInStoreById(productId) {
     .then((response) => response.body);
 }
 
-export async function getProductsInCurrentStore() {
+export async function getProductsInCurrentStore(storeKey) {
   let lastProductId = undefined;
   let hasNextQuery = true;
   let allProducts = [];
@@ -36,7 +36,7 @@ export async function getProductsInCurrentStore() {
 
     let productChunk = await createApiRoot()
       .inStoreKeyWithStoreKeyValue({
-        storeKey: Buffer.from(process.env.CTP_STORE_KEY).toString(),
+        storeKey: Buffer.from(storeKey).toString(),
       })
       .productSelectionAssignments()
       .get({ queryArgs })

diff --git a/full-ingestion/src/controllers/sync.controller.js b/full-ingestion/src/controllers/sync.controller.js
@@ -15,9 +15,9 @@ import {
   HTTP_STATUS_SUCCESS_NO_CONTENT,
 } from '../constants/http.status.constants.js';
 
-async function syncProducts() {
+async function syncProducts(storeKey) {
   let productsToBeSynced = [];
-  const products = await getProductsInCurrentStore();
+  const products = await getProductsInCurrentStore(storeKey);
 
   //Clean up search index before full sychronization
   const productIdsToBeRemoved = products.map((product) => product.id);
@@ -26,6 +26,7 @@ async function syncProducts() {
   for (let productInCurrentStore of products) {
     let productToBeSynced = undefined;
     productToBeSynced = await getProductProjectionInStoreById(
+      storeKey,
       productInCurrentStore.id
     ).catch(async (error) => {
       // Product cannot be found in store assignment. Need to remove product in external search index