test(sync-action): test adding newly master variant#1702
Closed
markus-azer wants to merge 1 commit intomasterfrom
Closed
test(sync-action): test adding newly master variant#1702markus-azer wants to merge 1 commit intomasterfrom
markus-azer wants to merge 1 commit intomasterfrom
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1702 +/- ##
=======================================
Coverage 98.65% 98.65%
=======================================
Files 128 128
Lines 3427 3427
Branches 791 791
=======================================
Hits 3381 3381
Misses 42 42
Partials 4 4 Continue to review full report at Codecov.
|
islam3zzat
reviewed
Sep 30, 2021
| test('should add newly added masterVariant as first `addVariant` ', () => { | ||
| const actions = productsSync.buildActions(now, before) | ||
|
|
||
| expect(actions[0]).toEqual({ |
Contributor
There was a problem hiding this comment.
Is this redundant since we do an assertion on all the actions?
Member
Author
|
too old PR |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
addVariantaction.Description
Todo
Typelabel for the PR