Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reenable polysemy #4976

Merged
merged 1 commit into from
Nov 20, 2019
Merged

Reenable polysemy #4976

merged 1 commit into from
Nov 20, 2019

Conversation

isovector
Copy link
Contributor

Checklist:

  • Meaningful commit message, eg add my-cool-package (please not mention build-constraints.yml)

  • At least 30 minutes have passed since uploading to Hackage

  • On your own machine, in a new directory, you have successfully run the following set of commands (replace $package with the name of the package that is submitted, and $version with the version of the package you want to get into Stackage):

    stack unpack $package-$version  # $version is optional
    stack init --resolver nightly
    stack build --resolver nightly --haddock --test --bench --no-run-benchmarks
    

Y'all didn't inform me of the breakage!

@isovector
Copy link
Contributor Author

I don't know why CI is failing here. Can someone from the stack team please help?

@cdornan
Copy link
Contributor

cdornan commented Nov 16, 2019

@isovector the check failed because dependent packages loopbreaker and unagi-chan are not in nightly atm. Leave it with me for now — shpould be able to get it into nightly on Monday.

@isovector
Copy link
Contributor Author

Thanks @cdornan --- we really appreciate the air support on this!

@DanBurton DanBurton merged commit b33d400 into commercialhaskell:master Nov 20, 2019
@DanBurton
Copy link
Contributor

As Chris mentioned, this required re-enabling loopbreaker and unagi-chan.

loopbreaker may not be functioning correctly on ghc 8.8; I've marked this as an expected test failure for now, but note that this may cause performance regressions. polysemy-research/loopbreaker#10

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants