cppgen: improved support of fields of type 'any' #893
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Dec 2, 2024
mr-c
changed the title
mr-c
requested changes
Dec 3, 2024
Member
mr-c
left a comment
mr-c
left a comment
There was a problem hiding this comment.
Thank you @SGSSGene ! Can you fix the unit-test errors? Looks like the examples in https://github.com/common-workflow-language/schema_salad/tree/main/schema_salad/tests/cpp_tests need to be refreshed with the new syntax
Currently, types of 'any' are simply ignored when generating output. This improves the handling of 'any' by adding explicit conversions to: - float - double - char - int8_t - uint8_t - int16_t - uint16_t - int32_t - uint32_t - int64_t - uint64_t and - std::string required to fix deNBI-cibi/tool_description_lib#59
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #893 +/- ##
=======================================
Coverage 83.14% 83.14%
=======================================
Files 22 22
Lines 4900 4900
Branches 1178 1178
=======================================
Hits 4074 4074
Misses 548 548
Partials 278 278 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, types of 'any' are simply ignored when generating output. This improves the handling of 'any' by adding explicit conversions to:
required to fix deNBI-cibi/tool_description_lib#59
also uploaded a new generated version to: common-workflow-lab/cwl-cpp-auto#11