Allow Detection of WWW Autolinks #406
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
robinst
requested changes
Oct 6, 2025
|
|
||
| if (linkTypes.length == 0) { | ||
| throw new IllegalArgumentException("linkTypes must not be empty"); | ||
| } |
There was a problem hiding this comment.
No need to duplicate the checks above if we're delegating to linkTypes(Set<AutolinkType> linkTypes) anyway.
There was a problem hiding this comment.
Removed the second check. The first check was just to provide a more explicit error message than whatever is thrown by calling Set.of(null), but I can remove if we think that's unnecessary.
...k-ext-autolink/src/main/java/org/commonmark/ext/autolink/internal/AutolinkPostProcessor.java
Outdated
Show resolved
Hide resolved
...k-ext-autolink/src/main/java/org/commonmark/ext/autolink/internal/AutolinkPostProcessor.java
Outdated
Show resolved
Hide resolved
...k-ext-autolink/src/main/java/org/commonmark/ext/autolink/internal/AutolinkPostProcessor.java
Outdated
Show resolved
Hide resolved
...k-ext-autolink/src/main/java/org/commonmark/ext/autolink/internal/AutolinkPostProcessor.java
Show resolved
Hide resolved
rdestefa
commented
Oct 6, 2025
|
Thanks for the reviews! I think all comments should be addressed now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements #298. Would be nice to have this additional functionality, so took a stab at a PR for this.
Can add a changelog entry if the current approach looks good.