[WIP] launcherlib: Fix "different visibility" warning including GenerateExportHeader #76
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ortHeader This commit is an attempt to "different visibility" warning [1]. By including "GenerateExportHeader" header, it automatically run the try_compile checking if compiler support "visibility" flags and set option "USE_COMPILER_HIDDEN_VISIBILITY" to ON if it makes sense. [...] -- Checking to see if CXX compiler accepts flag -fvisibility=hidden -- Checking to see if CXX compiler accepts flag -fvisibility=hidden - yes -- Performing Test COMPILER_HAS_HIDDEN_VISIBILITY -- Performing Test COMPILER_HAS_HIDDEN_VISIBILITY - Success -- Performing Test COMPILER_HAS_HIDDEN_INLINE_VISIBILITY -- Performing Test COMPILER_HAS_HIDDEN_INLINE_VISIBILITY - Success -- Performing Test COMPILER_HAS_DEPRECATED_ATTR -- Performing Test COMPILER_HAS_DEPRECATED_ATTR - Success [...] [1] Slicer/Slicer#727 (comment)
jcfr
force-pushed
the
export-header-and-include-visibility-hidden-flag
branch
from
618d382
to
53935a2
Compare
|
Revisit this and remove CMake function |
jcfr
changed the title
jcfr
force-pushed
the
master
branch
5 times, most recently
from
9b578a5
to
e70f8b5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit is an attempt to "different visibility" warning [1]. By including
"GenerateExportHeader" header, it automatically run the try_compile checking
if compiler support "visibility" flags and set option "USE_COMPILER_HIDDEN_VISIBILITY"
to ON if it makes sense.