Skip to content

Initial review (@BrendanChou)

66cb956
Select commit
Loading
Failed to load commit list.
Open

[consensus/marshal] Erasure coding #2208

Initial review (@BrendanChou)
66cb956
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Jan 29, 2026 in 1s

91.98% (-0.15%) compared to 4fbfebb

View this Pull Request on Codecov

91.98% (-0.15%) compared to 4fbfebb

Details

Codecov Report

❌ Patch coverage is 84.18367% with 527 lines in your changes missing coverage. Please review.
✅ Project coverage is 91.98%. Comparing base (4fbfebb) to head (66cb956).

Files with missing lines Patch % Lines
consensus/src/marshal/coding/marshaled.rs 46.24% 229 Missing ⚠️
consensus/src/marshal/coding/actor.rs 85.64% 90 Missing ⚠️
consensus/src/marshal/coding/shards/engine.rs 89.24% 67 Missing ⚠️
consensus/src/marshal/standard/actor.rs 93.38% 42 Missing ⚠️
consensus/src/marshal/coding/types.rs 91.91% 30 Missing ⚠️
consensus/src/marshal/coding/cache.rs 90.36% 21 Missing ⚠️
storage/src/metadata/storage.rs 0.00% 14 Missing ⚠️
consensus/src/types.rs 78.18% 12 Missing ⚠️
consensus/src/marshal/coding/shards/mailbox.rs 85.18% 8 Missing ⚠️
consensus/src/marshal/coding/mailbox.rs 93.68% 6 Missing ⚠️
... and 3 more
@@            Coverage Diff             @@
##             main    #2208      +/-   ##
==========================================
- Coverage   92.12%   91.98%   -0.15%     
==========================================
  Files         389      399      +10     
  Lines      123871   128444    +4573     
==========================================
+ Hits       114120   118149    +4029     
- Misses       9751    10295     +544     
Files with missing lines Coverage Δ
coding/src/lib.rs 98.46% <ø> (+6.15%) ⬆️
coding/src/zoda.rs 94.73% <ø> (ø)
consensus/src/lib.rs 0.00% <ø> (ø)
consensus/src/marshal/coding/mod.rs 95.08% <ø> (ø)
consensus/src/marshal/mocks/application.rs 100.00% <100.00%> (ø)
consensus/src/marshal/mocks/block.rs 100.00% <100.00%> (ø)
consensus/src/marshal/mod.rs 54.54% <ø> (-39.71%) ⬇️
consensus/src/marshal/resolver/p2p.rs 100.00% <100.00%> (ø)
consensus/src/marshal/standard/cache.rs 95.31% <100.00%> (ø)
consensus/src/marshal/standard/mailbox.rs 100.00% <100.00%> (ø)
... and 16 more

... and 12 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4fbfebb...66cb956. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.