feat(storage,consensus): add index_for_key to Archive trait #2633
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add a new method to efficiently retrieve the index (height) for a given key without fetching the full value. This optimizes the case where only the height is needed from a block commitment. Changes: - storage: Add index_for_key method to Archive trait - storage: Implement optimized version for prunable::Archive using in-memory keys map - storage: Add fallback (returns None) for immutable::Archive due to structural limitations - consensus: Add get_height method to Blocks trait - consensus: Use get_height in Actor to resolve TODO at line 345 The prunable::Archive can now return the index directly from its in-memory mapping, avoiding the need to deserialize the full block.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add index_for_key method to Archive trait and get_height to Blocks trait for retrieving block height from commitment without deserializing the full block.
Note : Optimization applies to prunable archive only. Immutable archive falls back to full block fetch.