[p2p] Bound Block Duration #2666
Conversation
Deploying with
|
| Status | Name | Latest Commit | Updated (UTC) |
|---|---|---|---|
| ✅ Deployment successful! View logs |
commonware-mcp | 7a189ef | Jan 04 2026, 06:47 PM |
Deploying monorepo with
|
| Latest commit: |
7a189ef
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://8cf19121.monorepo-eu0.pages.dev |
| Branch Preview URL: | https://just-bounded-block.monorepo-eu0.pages.dev |
| self.metrics.blocked.dec(); | ||
| } | ||
|
|
||
| // We don't decrement the blocked metric here because the block |
There was a problem hiding this comment.
This is a slight functional change that won't matter in typical operation but does feel more correct to me.
| } | ||
|
|
||
| #[test] | ||
| fn test_listenable_ip_collision_eligible_wins() { |
There was a problem hiding this comment.
This was added as a regression test but the code was/is correct (allowed this already)
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
|
Going to dedup the block state tracking a bit. |
|
|
||
| /// Tracks blocked peers and their unblock time. This is the source of truth for | ||
| /// whether a peer is blocked, persisting even if the peer record is deleted. | ||
| blocked: PrioritySet<C, SystemTime>, |
There was a problem hiding this comment.
Now that blocking outlives records, we track here (and remove any notion of blocking from records).
Codecov Report❌ Patch coverage is @@ Coverage Diff @@
## main #2666 +/- ##
==========================================
- Coverage 92.77% 92.77% -0.01%
==========================================
Files 362 362
Lines 105115 106074 +959
==========================================
+ Hits 97525 98412 +887
- Misses 7590 7662 +72
... and 1 file with indirect coverage changes Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
Replaces: #2570 (includes metrics changes + bound changes)