Skip to content

Conversation

@andresilva
Copy link
Collaborator

@andresilva andresilva commented Jan 3, 2026

Uses aws-lc-rs for secp256r1 signature verification on x86_64 and aarch64. This provides a C/assembly backend similar to blst (BLS12-381), significantly improving on the performance of pure-Rust p256.

We still retain p256 for signing (for RFC6979) and for recoverable signatures. Falls back to the p256 crate on other architectures (e.g., wasm32).

Fixes #2681

Performance

Implementation Verification Time Speedup
p256 (pure Rust) ~192 µs baseline
aws-lc-rs ~34 µs 5.7x faster

@cloudflare-workers-and-pages
Copy link

cloudflare-workers-and-pages bot commented Jan 3, 2026

Deploying monorepo with  Cloudflare Pages  Cloudflare Pages

Latest commit: 747cfb5
Status: ✅  Deploy successful!
Preview URL: https://1a6677e6.monorepo-eu0.pages.dev
Branch Preview URL: https://andre-exclude-1k-secp256r1-t.monorepo-eu0.pages.dev

View logs

@cloudflare-workers-and-pages
Copy link

cloudflare-workers-and-pages bot commented Jan 3, 2026

Deploying with  Cloudflare Workers  Cloudflare Workers

The latest updates on your project. Learn more about integrating Git with Workers.

Status Name Latest Commit Updated (UTC)
✅ Deployment successful!
View logs
commonware-mcp 747cfb5 Jan 03 2026, 07:53 PM

patrick-ogrady
patrick-ogrady previously approved these changes Jan 3, 2026
@patrick-ogrady patrick-ogrady added this pull request to the merge queue Jan 3, 2026
@patrick-ogrady patrick-ogrady removed this pull request from the merge queue due to a manual request Jan 3, 2026
@patrick-ogrady patrick-ogrady changed the title [consensus] exclude hanging 1k_secp256r1 tests from coverage [cryptography] use aws-lc-rs for optimized secp256r1 verification Jan 3, 2026
🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude Opus 4.5 <[email protected]>
@patrick-ogrady patrick-ogrady merged commit 6776470 into main Jan 3, 2026
126 checks passed
@patrick-ogrady patrick-ogrady deleted the andre/exclude-1k-secp256r1-test-coverage branch January 3, 2026 20:44
@codecov
Copy link

codecov bot commented Jan 3, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 92.77%. Comparing base (6deffb6) to head (747cfb5).
⚠️ Report is 4 commits behind head on main.

@@            Coverage Diff             @@
##             main    #2680      +/-   ##
==========================================
+ Coverage   92.63%   92.77%   +0.14%     
==========================================
  Files         357      362       +5     
  Lines      103102   105115    +2013     
==========================================
+ Hits        95505    97525    +2020     
+ Misses       7597     7590       -7     
Files with missing lines Coverage Δ
cryptography/src/secp256r1/common.rs 88.00% <100.00%> (+1.18%) ⬆️
cryptography/src/secp256r1/standard.rs 95.65% <100.00%> (+2.22%) ⬆️

... and 8 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 59fcc5a...747cfb5. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[consensus] investigate why 1k_secp256r1 tests hang under coverage

3 participants