[cryptography] use aws-lc-rs for optimized secp256r1 verification #2684
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deploying with
|
| Status | Name | Latest Commit | Updated (UTC) |
|---|---|---|---|
| ✅ Deployment successful! View logs |
commonware-mcp | 266c93c | Jan 03 2026, 07:19 PM |
patrick-ogrady
force-pushed
the
only-instrument-workspace
branch
from
40fe594 to
86fbf15
Compare
Deploying monorepo with
|
| Latest commit: |
266c93c
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://d9ee1813.monorepo-eu0.pages.dev |
| Branch Preview URL: | https://only-instrument-workspace.monorepo-eu0.pages.dev |
patrick-ogrady
force-pushed
the
only-instrument-workspace
branch
3 times, most recently
from
920cbb1 to
9e638f8
Compare
The p256 crate (used for secp256r1) is pure Rust with no assembly/C backend, unlike blst (BLS12-381) which uses C with assembly, or ed25519-consensus which has optimized backends. When LLVM coverage instrumentation was applied via RUSTFLAGS, all Rust code including dependencies got instrumented. The tight cryptographic loops in p256 became significantly slower due to instrumentation overhead, causing the 1000-view secp256r1 tests to timeout. This change uses RUSTC_WORKSPACE_WRAPPER to only instrument workspace crates, not dependencies. A wrapper script adds the coverage flags only when invoked by Cargo for workspace crates, leaving dependencies uninstrumented. Fixes #2681 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <[email protected]>
patrick-ogrady
force-pushed
the
only-instrument-workspace
branch
from
9e638f8 to
9972965
Compare
- Add aws-lc-rs dependency for x86_64 and aarch64 platforms - Use aws-lc-rs for P-256 ECDSA verification (~4-6x faster) - Keep p256 for signing (preserves RFC 6979 deterministic signatures) - Automatic platform detection (no feature flag needed) - Falls back to p256 on unsupported platforms (WASM, etc.) 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <[email protected]>
🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <[email protected]>
🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <[email protected]>
🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <[email protected]>
🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <[email protected]>
patrick-ogrady
changed the title
patrick-ogrady
merged commit fd8d2bb
into
andre/exclude-1k-secp256r1-test-coverage
119 checks passed
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## andre/exclude-1k-secp256r1-test-coverage #2684 +/- ##
=========================================================================
Coverage 92.77% 92.77%
=========================================================================
Files 362 362
Lines 105109 105115 +6
=========================================================================
+ Hits 97518 97525 +7
+ Misses 7591 7590 -1
... and 1 file with indirect coverage changes Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uses aws-lc-rs for secp256r1 signature verification on x86_64 and aarch64. This provides a C/assembly backend similar to blst (BLS12-381), significantly improving on the performance of pure-Rust p256.
We still retain p256 for signing (for RFC6979) and for recoverable signatures. Falls back to the p256 crate on other architectures (e.g., wasm32).
Fixes #2681
Performance