[p2p] Distinguish Rejection Reason #2686
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deploying with
|
| Status | Name | Latest Commit | Updated (UTC) |
|---|---|---|---|
| ✅ Deployment successful! View logs |
commonware-mcp | a2d2d46 | Jan 04 2026, 08:33 PM |
patrick-ogrady
force-pushed
the
patrick/improve-logging-metrics-listener
branch
from
e42c969 to
ab9e1e8
Compare
Deploying monorepo with
|
| Latest commit: |
a2d2d46
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://10e0a6d5.monorepo-eu0.pages.dev |
| Branch Preview URL: | https://patrick-improve-logging-metr.monorepo-eu0.pages.dev |
Add an `Attempt` enum to provide specific rejection reasons when refusing incoming connections. Previously, both lookup and discovery listeners used generic metrics/logging that didn't distinguish between different rejection causes, making debugging difficult. The `Attempt` enum has variants for: Ok, Blocked, Unregistered, Reserved (already connected), Mismatch (e.g., IP doesn't match), and Myself (trying to connect to ourselves). Changes: - Add shared `Attempt` enum in `authenticated/mod.rs` - Update record `acceptable()` methods to return `Attempt` - Update directory `acceptable()` to check blocked status and increment specific metrics (rejected_blocked, rejected_unregistered, rejected_reserved, rejected_mismatch, rejected_myself) - Update listeners to convert `Attempt` to bool for stream crate - Add `ListenableIps` struct with `allowed` and `blocked` sets to enable proper IP-level metrics in lookup listener - Add `handshakes_ip_blocked` metric for blocked peer IPs (pre-handshake) - Add `handshakes_ip_unregistered` metric for unregistered IPs 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <[email protected]>
patrick-ogrady
force-pushed
the
patrick/improve-logging-metrics-listener
branch
from
ab9e1e8 to
a2d2d46
Compare
Codecov Report❌ Patch coverage is @@ Coverage Diff @@
## main #2686 +/- ##
========================================
Coverage 92.77% 92.78%
========================================
Files 362 362
Lines 106074 106203 +129
========================================
+ Hits 98412 98537 +125
- Misses 7662 7666 +4
... and 1 file with indirect coverage changes Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related: #2570