-
Notifications
You must be signed in to change notification settings - Fork 170
[cryptography] Namespace as Scheme Nits #2688
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[cryptography] Namespace as Scheme Nits #2688
Conversation
Deploying monorepo with
|
| Latest commit: |
52fcfe5
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://625dc77c.monorepo-eu0.pages.dev |
| Branch Preview URL: | https://review-nits.monorepo-eu0.pages.dev |
Deploying with
|
| Status | Name | Latest Commit | Updated (UTC) |
|---|---|---|---|
| ✅ Deployment successful! View logs |
commonware-mcp | 52fcfe5 | Jan 05 2026, 05:33 AM |
| // Application namespace | ||
| namespace: Vec<u8>, | ||
| // Verifier for node signatures. | ||
| node_verifier: NodeVerifier, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: verifier
|
bugbot run |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
✅ Bugbot reviewed your changes and found no bugs!
3c6ad1e
into
andre/consensus-avoid-namespace-recomputation
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## andre/consensus-avoid-namespace-recomputation #2688 +/- ##
==============================================================================
Coverage 92.77% 92.77%
==============================================================================
Files 362 362
Lines 105064 105102 +38
==============================================================================
+ Hits 97476 97512 +36
- Misses 7588 7590 +2
... and 1 file with indirect coverage changes Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
Related: #2559