Skip to content

Conversation

@patrick-ogrady
Copy link
Contributor

@patrick-ogrady patrick-ogrady commented Jan 5, 2026

Related: #2559

@cloudflare-workers-and-pages
Copy link

cloudflare-workers-and-pages bot commented Jan 5, 2026

Deploying monorepo with  Cloudflare Pages  Cloudflare Pages

Latest commit: 52fcfe5
Status: ✅  Deploy successful!
Preview URL: https://625dc77c.monorepo-eu0.pages.dev
Branch Preview URL: https://review-nits.monorepo-eu0.pages.dev

View logs

@cloudflare-workers-and-pages
Copy link

cloudflare-workers-and-pages bot commented Jan 5, 2026

Deploying with  Cloudflare Workers  Cloudflare Workers

The latest updates on your project. Learn more about integrating Git with Workers.

Status Name Latest Commit Updated (UTC)
✅ Deployment successful!
View logs
commonware-mcp 52fcfe5 Jan 05 2026, 05:33 AM

// Application namespace
namespace: Vec<u8>,
// Verifier for node signatures.
node_verifier: NodeVerifier,
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: verifier

@patrick-ogrady
Copy link
Contributor Author

bugbot run

Copy link

@cursor cursor bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Bugbot reviewed your changes and found no bugs!

@patrick-ogrady patrick-ogrady marked this pull request as ready for review January 5, 2026 05:48
@patrick-ogrady patrick-ogrady merged commit 3c6ad1e into andre/consensus-avoid-namespace-recomputation Jan 5, 2026
118 checks passed
@patrick-ogrady patrick-ogrady deleted the review-nits branch January 5, 2026 05:48
@codecov
Copy link

codecov bot commented Jan 5, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 92.77%. Comparing base (4c7da9f) to head (52fcfe5).
⚠️ Report is 1 commits behind head on andre/consensus-avoid-namespace-recomputation.

@@                              Coverage Diff                               @@
##           andre/consensus-avoid-namespace-recomputation    #2688   +/-   ##
==============================================================================
  Coverage                                          92.77%   92.77%           
==============================================================================
  Files                                                362      362           
  Lines                                             105064   105102   +38     
==============================================================================
+ Hits                                               97476    97512   +36     
- Misses                                              7588     7590    +2     
Files with missing lines Coverage Δ
consensus/src/aggregation/mod.rs 98.73% <100.00%> (ø)
consensus/src/aggregation/types.rs 98.68% <100.00%> (ø)
consensus/src/marshal/mod.rs 95.28% <100.00%> (ø)
consensus/src/ordered_broadcast/ack_manager.rs 99.32% <100.00%> (ø)
consensus/src/ordered_broadcast/engine.rs 85.95% <100.00%> (ø)
consensus/src/ordered_broadcast/mocks/reporter.rs 85.82% <100.00%> (ø)
consensus/src/ordered_broadcast/mod.rs 99.06% <100.00%> (+0.01%) ⬆️
consensus/src/ordered_broadcast/tip_manager.rs 100.00% <100.00%> (ø)
consensus/src/ordered_broadcast/types.rs 97.31% <100.00%> (+0.06%) ⬆️
consensus/src/simplex/actors/batcher/mod.rs 97.45% <100.00%> (ø)
... and 18 more

... and 1 file with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4c7da9f...52fcfe5. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants