[consensus/simplex] Add Voting Metrics #2708
Conversation
Deploying with
|
| Status | Name | Latest Commit | Updated (UTC) |
|---|---|---|---|
| ✅ Deployment successful! View logs |
commonware-mcp | cf2cc46 | Jan 06 2026, 07:25 PM |
patrick-ogrady
force-pushed
the
patrick/consensus-metrics
branch
from
e2638a1 to
f842cdb
Compare
Deploying monorepo with
|
| Latest commit: |
cf2cc46
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://8a8afa05.monorepo-eu0.pages.dev |
| Branch Preview URL: | https://patrick-consensus-metrics.monorepo-eu0.pages.dev |
patrick-ogrady
force-pushed
the
patrick/consensus-metrics
branch
from
f842cdb to
545ed1b
Compare
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
|
While honest voters should never vote for views lower than latest, we want this metric to be robust to such behavior. |
Add a family gauge metric to track the view of the latest vote received from each participant in the batcher actor. This enables monitoring peer activity and computing instantaneous lag (current_view - latest_vote). - Add Peer label struct to metrics.rs - Add GaugeExt::set_max helper to update gauge only if value is higher - Initialize all participants to view 0 at startup - Update metric when valid votes are received (after epoch check) - Add test verifying metric tracking including late votes after quorum and ensuring lower view votes don't decrease the metric 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <[email protected]>
patrick-ogrady
force-pushed
the
patrick/consensus-metrics
branch
2 times, most recently
from
2c3ea3f to
1ca9845
Compare
| let latest_vote = Family::<Peer, Gauge>::default(); | ||
| context.register( | ||
| "latest_vote", | ||
| "view of latest vote received per peer", |
There was a problem hiding this comment.
This may be annoying to work with in practice in something like reshare because we namespace metrics by epoch (so you'd have to constantly be updating your dashboard I think?)
But that should be considered in a follow-up.
- Rename set_max to try_set_max for consistency with try_set - Inline participants clone where needed 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <[email protected]>
🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <[email protected]>
🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <[email protected]>
| let _ = self | ||
| .latest_vote | ||
| .get_or_create(&peer) | ||
| .try_set_max(view.get()); |
There was a problem hiding this comment.
Opted to move into post-network validation to avoid duplicating its checks (to ensure a peer, for example is in participants -> thank you based bugbot).
There was a problem hiding this comment.
This shouldn't happen with our current p2p but we should be defensive.
Codecov Report❌ Patch coverage is
@@ Coverage Diff @@
## main #2708 +/- ##
========================================
Coverage 92.81% 92.82%
========================================
Files 361 361
Lines 107038 107218 +180
========================================
+ Hits 99352 99527 +175
- Misses 7686 7691 +5
... and 1 file with indirect coverage changes Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
Related: #1921 (production-use adaption)
Add a family gauge metric to track the view of the last vote received from each participant in the batcher actor. This enables monitoring peer activity and computing instantaneous lag (current_view - last_vote).