-
Notifications
You must be signed in to change notification settings - Fork 170
Secure setup action config #2709
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Deploying with
|
| Status | Name | Latest Commit | Updated (UTC) |
|---|---|---|---|
| ✅ Deployment successful! View logs |
commonware-mcp | 4c1fdde | Jan 08 2026, 05:20 PM |
Deploying monorepo with
|
| Latest commit: |
4c1fdde
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://809cf85c.monorepo-eu0.pages.dev |
| Branch Preview URL: | https://denis-secure-setup-action.monorepo-eu0.pages.dev |
.github/workflows/docker.yml
Outdated
| export TARGET="${GIT_REF_NAME%/*}" | ||
| fi | ||
| echo "Target: $TARGET" | ||
| echo "Target: "${INPUT_TARGET}" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Unclosed quote causes bash syntax error in workflow
High Severity
The line echo "Target: "${INPUT_TARGET}" has malformed quoting - the string "Target: " is closed, then ${INPUT_TARGET} is unquoted, and a trailing " opens a new quote that's never closed. This causes a bash syntax error that will fail the workflow. Additionally, the original code printed $TARGET (the potentially-modified value) but this prints ${INPUT_TARGET} (the raw input), which changes the debugging output behavior.
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## main #2709 +/- ##
==========================================
+ Coverage 92.82% 93.20% +0.37%
==========================================
Files 361 372 +11
Lines 106797 113359 +6562
==========================================
+ Hits 99134 105655 +6521
- Misses 7663 7704 +41 see 152 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
This PR hardens the GitHub action config.