Fix mmr_journaled fuzz test #2744
Conversation
Deploying with
|
| Status | Name | Latest Commit | Updated (UTC) |
|---|---|---|---|
| ✅ Deployment successful! View logs |
commonware-mcp | bb1e029 | Jan 08 2026, 03:03 PM |
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
|
|
||
| runner.start(|context| async move { | ||
| let mut leaves = Vec::new(); | ||
| let mut leaves_synced = true; |
There was a problem hiding this comment.
Initial init missing leaves_synced check for recovered data
Low Severity
The leaves_synced variable is initialized to true at startup, but after the initial Mmr::init() call, there's no check for whether the MMR recovered existing data. This is inconsistent with the Reinit operation which correctly sets leaves_synced = new_mmr.leaves() == 0. If the initial init recovers data, the leaves vector will be empty but leaves_synced will be true, causing proof operations to be silently skipped rather than exercised without verification (the intended fallback behavior for unsynced state).
Additional Locations (1)
|
Closing this in favor of #2746 |
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## main #2744 +/- ##
==========================================
+ Coverage 93.17% 93.20% +0.03%
==========================================
Files 369 372 +3
Lines 111514 113359 +1845
==========================================
+ Hits 103902 105657 +1755
- Misses 7612 7702 +90 see 69 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
This PR fixes
mmr_journaledfuzz test.