Skip to content

Conversation

@danlaine
Copy link
Collaborator

@danlaine danlaine commented Jan 8, 2026

With this change, all qmdb::any databases all support state sync.

  • The unordered variants already had state sync. storage/src/qmdb/any/unordered/fixed/sync.rs and storage/src/qmdb/any/unordered/fixed/sync.rs have been deleted, as their contents have been factored out.
  • init_journal and init_journal_at_size moved from storage/src/qmdb/any/unordered/fixed/sync.rs to storage/src/journal/contiguous/fixed.rs. This matches the pattern used by storage/src/journal/contiguous/variable.rs.
  • Increases visibility of some mod tests to share helper code.
  • Adds macro to generate Resolver implementations for each database variant.

@danlaine danlaine self-assigned this Jan 8, 2026
@danlaine danlaine added this to Tracker Jan 8, 2026
@cloudflare-workers-and-pages
Copy link

cloudflare-workers-and-pages bot commented Jan 8, 2026

Deploying with  Cloudflare Workers  Cloudflare Workers

The latest updates on your project. Learn more about integrating Git with Workers.

Status Name Latest Commit Updated (UTC)
✅ Deployment successful!
View logs
commonware-mcp 39044bc Jan 09 2026, 03:15 AM

@danlaine danlaine moved this to In Progress in Tracker Jan 8, 2026
@cloudflare-workers-and-pages
Copy link

cloudflare-workers-and-pages bot commented Jan 8, 2026

Deploying monorepo with  Cloudflare Pages  Cloudflare Pages

Latest commit: 39044bc
Status: ✅  Deploy successful!
Preview URL: https://7e6f1fb7.monorepo-eu0.pages.dev
Branch Preview URL: https://danlaine-sync-ordered.monorepo-eu0.pages.dev

View logs

@@ -0,0 +1,220 @@
//! An authenticated database that provides succinct proofs of _any_ value ever associated
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Moved from storage/src/qmdb/any/ordered/variable.rs

@codecov
Copy link

codecov bot commented Jan 9, 2026

Codecov Report

❌ Patch coverage is 96.71302% with 26 lines in your changes missing coverage. Please review.
✅ Project coverage is 93.31%. Comparing base (aaa095f) to head (39044bc).

Files with missing lines Patch % Lines
storage/src/qmdb/sync/resolver.rs 65.85% 14 Missing ⚠️
storage/src/journal/contiguous/fixed.rs 98.67% 4 Missing ⚠️
storage/src/qmdb/any/sync/impls.rs 95.91% 4 Missing ⚠️
storage/src/qmdb/any/ordered/variable.rs 97.10% 2 Missing ⚠️
storage/src/qmdb/any/unordered/variable.rs 95.23% 2 Missing ⚠️
@@            Coverage Diff             @@
##             main    #2748      +/-   ##
==========================================
+ Coverage   93.29%   93.31%   +0.02%     
==========================================
  Files         372      373       +1     
  Lines      114273   114294      +21     
==========================================
+ Hits       106610   106659      +49     
+ Misses       7663     7635      -28     
Files with missing lines Coverage Δ
storage/src/index/ordered.rs 100.00% <100.00%> (ø)
storage/src/index/unordered.rs 100.00% <100.00%> (ø)
storage/src/journal/contiguous/variable.rs 97.83% <100.00%> (-0.01%) ⬇️
storage/src/mmr/journaled.rs 92.27% <100.00%> (ø)
storage/src/qmdb/any/mod.rs 100.00% <ø> (ø)
storage/src/qmdb/any/ordered/fixed.rs 99.56% <100.00%> (+<0.01%) ⬆️
storage/src/qmdb/any/ordered/mod.rs 96.55% <ø> (ø)
storage/src/qmdb/any/sync/mod.rs 100.00% <100.00%> (ø)
storage/src/qmdb/any/sync/tests.rs 99.13% <100.00%> (ø)
storage/src/qmdb/any/unordered/fixed.rs 99.49% <ø> (ø)
... and 10 more

... and 1 file with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update aaa095f...39044bc. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: In Progress

Development

Successfully merging this pull request may close these issues.

2 participants