-
Notifications
You must be signed in to change notification settings - Fork 174
[consensus/simplex] Fix Seedable impl for bls12381_threshold scheme
#2756
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Deploying with
|
| Status | Name | Latest Commit | Updated (UTC) |
|---|---|---|---|
| ✅ Deployment successful! View logs |
commonware-mcp | 88ea01c | Jan 08 2026, 07:43 PM |
| /// operations such as signature recovery and batch verification run sequentially or in parallel. | ||
| #[derive(Clone, Debug)] | ||
| pub struct Scheme<P: PublicKey, V: Variant, S: Strategy = Sequential> { | ||
| pub struct Scheme<P: PublicKey, V: Variant, S: Strategy> { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Opted to remove the default strategy since it caused the silent API blunder.
f37cc14 to
88ea01c
Compare
Deploying monorepo with
|
| Latest commit: |
88ea01c
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://ab70f643.monorepo-eu0.pages.dev |
| Branch Preview URL: | https://cl-fix-seedable-threshold.monorepo-eu0.pages.dev |
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## main #2756 +/- ##
=======================================
Coverage 93.20% 93.20%
=======================================
Files 372 372
Lines 113359 113359
=======================================
Hits 105655 105655
Misses 7704 7704
Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
Overview
Fixes the
Seedableimplementation forbls12381_threshold::Schemein simplex. API blunder from #2621