Skip to content

Conversation

@clabby
Copy link
Collaborator

@clabby clabby commented Jan 8, 2026

Overview

Fixes the Seedable implementation for bls12381_threshold::Scheme in simplex. API blunder from #2621

@clabby clabby self-assigned this Jan 8, 2026
@cloudflare-workers-and-pages
Copy link

cloudflare-workers-and-pages bot commented Jan 8, 2026

Deploying with  Cloudflare Workers  Cloudflare Workers

The latest updates on your project. Learn more about integrating Git with Workers.

Status Name Latest Commit Updated (UTC)
✅ Deployment successful!
View logs
commonware-mcp 88ea01c Jan 08 2026, 07:43 PM

/// operations such as signature recovery and batch verification run sequentially or in parallel.
#[derive(Clone, Debug)]
pub struct Scheme<P: PublicKey, V: Variant, S: Strategy = Sequential> {
pub struct Scheme<P: PublicKey, V: Variant, S: Strategy> {
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Opted to remove the default strategy since it caused the silent API blunder.

@clabby clabby marked this pull request as draft January 8, 2026 19:40
@clabby clabby force-pushed the cl/fix-seedable-threshold branch from f37cc14 to 88ea01c Compare January 8, 2026 19:42
@cloudflare-workers-and-pages
Copy link

cloudflare-workers-and-pages bot commented Jan 8, 2026

Deploying monorepo with  Cloudflare Pages  Cloudflare Pages

Latest commit: 88ea01c
Status: ✅  Deploy successful!
Preview URL: https://ab70f643.monorepo-eu0.pages.dev
Branch Preview URL: https://cl-fix-seedable-threshold.monorepo-eu0.pages.dev

View logs

@clabby clabby marked this pull request as ready for review January 8, 2026 19:43
@clabby clabby enabled auto-merge January 8, 2026 19:48
@clabby clabby added this pull request to the merge queue Jan 8, 2026
Merged via the queue into main with commit bd70106 Jan 8, 2026
130 checks passed
@clabby clabby deleted the cl/fix-seedable-threshold branch January 8, 2026 21:40
@codecov
Copy link

codecov bot commented Jan 8, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 93.20%. Comparing base (5ca1fb0) to head (88ea01c).
⚠️ Report is 4 commits behind head on main.

@@           Coverage Diff           @@
##             main    #2756   +/-   ##
=======================================
  Coverage   93.20%   93.20%           
=======================================
  Files         372      372           
  Lines      113359   113359           
=======================================
  Hits       105655   105655           
  Misses       7704     7704           
Files with missing lines Coverage Δ
consensus/src/marshal/mod.rs 95.28% <ø> (ø)
consensus/src/simplex/elector.rs 100.00% <ø> (ø)
consensus/src/simplex/mod.rs 98.77% <100.00%> (ø)
consensus/src/simplex/scheme/bls12381_threshold.rs 97.01% <100.00%> (ø)
consensus/src/simplex/scheme/reporter.rs 97.07% <100.00%> (ø)
consensus/src/simplex/types.rs 85.80% <ø> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5ca1fb0...88ea01c. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants