[consensus] Improve consensus' usage of Strategy
#2762
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deploying monorepo with
|
| Latest commit: |
91bf1d5
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://2cb95376.monorepo-eu0.pages.dev |
| Branch Preview URL: | https://cl-improve-consensus-paralle.monorepo-eu0.pages.dev |
Deploying with
|
| Status | Name | Latest Commit | Updated (UTC) |
|---|---|---|---|
| ✅ Deployment successful! View logs |
commonware-mcp | 91bf1d5 | Jan 09 2026, 04:54 AM |
clabby
commented
Jan 8, 2026
| rng: &mut R, | ||
| subject: Subject<'_, D>, | ||
| attestations: I, | ||
| _strategy: &impl Strategy, |
clabby
force-pushed
the
cl/improve-consensus-parallel-api
branch
from
804d8de to
2834155
Compare
clabby
changed the title
consensus' usage of Strategy
Resolve merge conflict in threshold.rs imports. Co-Authored-By: Claude Opus 4.5 <[email protected]>
…parallel-api # Conflicts: # consensus/src/simplex/actors/resolver/state.rs # consensus/src/simplex/actors/voter/round.rs # consensus/src/simplex/types.rs
patrick-ogrady
approved these changes
Jan 9, 2026
Codecov Report❌ Patch coverage is
@@ Coverage Diff @@
## main #2762 +/- ##
==========================================
+ Coverage 93.29% 93.31% +0.02%
==========================================
Files 372 372
Lines 114291 114643 +352
==========================================
+ Hits 106628 106983 +355
+ Misses 7663 7660 -3
... and 1 file with indirect coverage changes Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Improves the
consensuscrate's usage ofcommonware-parallel. Introduced in #2621, the threshold scheme was generic over theStrategytrait, which created a huge pain for downstream consumption. Now, the scheme's functions that can take advantage of theStrategyjust accept one, and the consensus engines feed it in.This PR is mainly focused on fixing up the API, which was very painful to integrate into alto beforehand. Performance improvements for the issues spotted in the alto deployment (commonwarexyz/alto#167) are delegated to #2759.