Skip to content

Conversation

@andresilva
Copy link
Member

Closes #2930.

@cloudflare-workers-and-pages
Copy link

cloudflare-workers-and-pages bot commented Jan 24, 2026

Deploying monorepo with  Cloudflare Pages  Cloudflare Pages

Latest commit: edc39d4
Status: ✅  Deploy successful!
Preview URL: https://b2d8560b.monorepo-eu0.pages.dev
Branch Preview URL: https://andre-select-loop-option.monorepo-eu0.pages.dev

View logs

@cloudflare-workers-and-pages
Copy link

cloudflare-workers-and-pages bot commented Jan 24, 2026

Deploying with  Cloudflare Workers  Cloudflare Workers

The latest updates on your project. Learn more about integrating Git with Workers.

Status Name Latest Commit Updated (UTC)
✅ Deployment successful!
View logs
commonware-mcp edc39d4 Jan 31 2026, 11:11 AM

@andresilva andresilva force-pushed the andre/select-loop-option branch from b0fe33a to 5a6c834 Compare January 24, 2026 13:59
@andresilva
Copy link
Member Author

Will update all usage sites after #2927.

@andresilva andresilva force-pushed the andre/select-loop-option branch 3 times, most recently from 359e19e to 855969a Compare January 24, 2026 15:37
Copy link

@cursor cursor bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 1 potential issue.

Bugbot Autofix is OFF. To automatically fix reported issues with Cloud Agents, enable Autofix in the Cursor dashboard.

@andresilva andresilva force-pushed the andre/select-loop-option branch from 855969a to 3ea00e7 Compare January 24, 2026 19:08
@andresilva andresilva moved this to Ready for Review in Tracker Jan 26, 2026
@andresilva andresilva self-assigned this Jan 26, 2026
@andresilva andresilva force-pushed the andre/select-loop-option branch from 3ea00e7 to 31a3cad Compare January 28, 2026 19:34
@codecov
Copy link

codecov bot commented Jan 31, 2026

Codecov Report

❌ Patch coverage is 75.83893% with 36 lines in your changes missing coverage. Please review.
✅ Project coverage is 93.12%. Comparing base (9f39fe3) to head (edc39d4).

Files with missing lines Patch % Lines
macros/impl/src/lib.rs 64.51% 11 Missing ⚠️
p2p/src/authenticated/lookup/actors/peer/actor.rs 25.00% 3 Missing ⚠️
consensus/src/aggregation/engine.rs 33.33% 2 Missing ⚠️
consensus/src/ordered_broadcast/engine.rs 33.33% 2 Missing ⚠️
...src/authenticated/discovery/actors/router/actor.rs 33.33% 2 Missing ⚠️
...rc/authenticated/discovery/actors/spawner/actor.rs 33.33% 2 Missing ⚠️
...rc/authenticated/discovery/actors/tracker/actor.rs 33.33% 2 Missing ⚠️
p2p/src/authenticated/lookup/actors/listener.rs 50.00% 2 Missing ⚠️
...2p/src/authenticated/lookup/actors/router/actor.rs 33.33% 2 Missing ⚠️
...p/src/authenticated/lookup/actors/spawner/actor.rs 33.33% 2 Missing ⚠️
... and 4 more
@@            Coverage Diff             @@
##             main    #2933      +/-   ##
==========================================
- Coverage   93.12%   93.12%   -0.01%     
==========================================
  Files         389      389              
  Lines      122706   122697       -9     
==========================================
- Hits       114274   114263      -11     
- Misses       8432     8434       +2     
Files with missing lines Coverage Δ
broadcast/src/buffered/engine.rs 94.28% <100.00%> (-0.03%) ⬇️
consensus/src/marshal/actor.rs 93.79% <100.00%> (-0.02%) ⬇️
consensus/src/simplex/actors/resolver/actor.rs 83.22% <100.00%> (+0.83%) ⬆️
consensus/src/simplex/actors/voter/actor.rs 97.77% <100.00%> (-0.01%) ⬇️
consensus/src/simplex/mocks/application.rs 94.89% <100.00%> (-0.08%) ⬇️
p2p/src/simulated/network.rs 95.73% <100.00%> (+0.40%) ⬆️
collector/src/p2p/engine.rs 85.95% <95.83%> (+0.58%) ⬆️
...p/src/authenticated/discovery/actors/peer/actor.rs 95.37% <50.00%> (-0.02%) ⬇️
consensus/src/aggregation/engine.rs 85.35% <33.33%> (+0.16%) ⬆️
consensus/src/ordered_broadcast/engine.rs 86.61% <33.33%> (-0.03%) ⬇️
... and 10 more

... and 1 file with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9f39fe3...edc39d4. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Ready for Review

Development

Successfully merging this pull request may close these issues.

[actors] Add Option<Message> Handling

2 participants