-
Notifications
You must be signed in to change notification settings - Fork 171
[github-workflow] run linter over bash scripts for PRs over main branch #373
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[github-workflow] run linter over bash scripts for PRs over main branch #373
Conversation
|
Shellcheck is already installed: https://github.com/actions/runner-images/blob/af0df299674bc781d6a4f891d9cea62b438e1332/images/ubuntu/Ubuntu2204-Readme.md?plain=1#L367 You should just need to do something like this: https://www.shellcheck.net/wiki/GitHub-Actions |
|
I did not see it as I use |
|
I moved some stuff around and updated the linter strictness. Once you fix the linting errors, will merge! |
Codecov ReportAll modified and coverable lines are covered by tests ✅
@@ Coverage Diff @@
## main #373 +/- ##
=======================================
Coverage 94.42% 94.43%
=======================================
Files 93 93
Lines 25128 25128
=======================================
+ Hits 23728 23730 +2
+ Misses 1400 1398 -2 see 2 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
patrick-ogrady
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
Closes #370