Skip to content

Conversation

@najeal
Copy link
Contributor

@najeal najeal commented Jan 19, 2025

Closes #370

@patrick-ogrady
Copy link
Contributor

patrick-ogrady commented Jan 20, 2025

Shellcheck is already installed: https://github.com/actions/runner-images/blob/af0df299674bc781d6a4f891d9cea62b438e1332/images/ubuntu/Ubuntu2204-Readme.md?plain=1#L367

You should just need to do something like this: https://www.shellcheck.net/wiki/GitHub-Actions

@najeal
Copy link
Contributor Author

najeal commented Jan 20, 2025

I did not see it as I use act to run the workflow locally I had error without installing it.
Change done 👍

@patrick-ogrady
Copy link
Contributor

I moved some stuff around and updated the linter strictness. Once you fix the linting errors, will merge!

@codecov
Copy link

codecov bot commented Jan 20, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.43%. Comparing base (ae50e2d) to head (fda7d94).
Report is 1 commits behind head on main.

@@           Coverage Diff           @@
##             main     #373   +/-   ##
=======================================
  Coverage   94.42%   94.43%           
=======================================
  Files          93       93           
  Lines       25128    25128           
=======================================
+ Hits        23728    23730    +2     
+ Misses       1400     1398    -2     

see 2 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ae50e2d...fda7d94. Read the comment docs.

@najeal najeal requested a review from patrick-ogrady January 20, 2025 15:25
Copy link
Contributor

@patrick-ogrady patrick-ogrady left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@patrick-ogrady patrick-ogrady merged commit 27c8cf6 into commonwarexyz:main Jan 20, 2025
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[CI] Add GitHub Action linter for bash scripts in scripts/

2 participants