-
Notifications
You must be signed in to change notification settings - Fork 20
fix(security): remove client-side UploadThing credentials #300
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 1 commit
Commits
Show all changes
3 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file was deleted.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
79 changes: 79 additions & 0 deletions
79
GenHub/GenHub.Tests/GenHub.Tests.Core/Features/Tools/Services/UploadHistoryServiceTests.cs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,79 @@ | ||
| using GenHub.Core.Interfaces.Common; | ||
| using GenHub.Features.Tools.Services; | ||
| using Microsoft.Extensions.Logging; | ||
| using Moq; | ||
|
|
||
| namespace GenHub.Tests.Core.Features.Tools.Services; | ||
|
|
||
| /// <summary> | ||
| /// Tests for local upload history behavior while cloud deletion is disabled. | ||
| /// </summary> | ||
| public sealed class UploadHistoryServiceTests : IDisposable | ||
| { | ||
| private readonly string _tempDirectory; | ||
|
|
||
| /// <summary> | ||
| /// Initializes a new instance of the <see cref="UploadHistoryServiceTests"/> class. | ||
| /// </summary> | ||
| public UploadHistoryServiceTests() | ||
| { | ||
| _tempDirectory = Path.Combine(Path.GetTempPath(), Guid.NewGuid().ToString()); | ||
| Directory.CreateDirectory(_tempDirectory); | ||
| } | ||
|
|
||
| /// <summary> | ||
| /// Removes temporary test data. | ||
| /// </summary> | ||
| public void Dispose() | ||
| { | ||
| if (Directory.Exists(_tempDirectory)) | ||
| { | ||
| Directory.Delete(_tempDirectory, recursive: true); | ||
| } | ||
|
|
||
| GC.SuppressFinalize(this); | ||
| } | ||
|
|
||
| /// <summary> | ||
| /// Verifies that removing an item deletes its local record immediately. | ||
| /// </summary> | ||
| /// <returns>A task representing the asynchronous test operation.</returns> | ||
| [Fact] | ||
| public async Task RemoveHistoryItemAsync_WhenItemExists_RemovesLocalRecord() | ||
| { | ||
| var service = CreateService(); | ||
| service.RecordUpload(1024, "https://utfs.io/f/example", "example.zip"); | ||
|
|
||
| await service.RemoveHistoryItemAsync("https://utfs.io/f/example"); | ||
|
|
||
| var reloadedService = CreateService(); | ||
| Assert.Empty(await reloadedService.GetUploadHistoryAsync()); | ||
| } | ||
|
|
||
| /// <summary> | ||
| /// Verifies that clearing history deletes every local record immediately. | ||
| /// </summary> | ||
| /// <returns>A task representing the asynchronous test operation.</returns> | ||
| [Fact] | ||
| public async Task ClearHistoryAsync_WhenItemsExist_RemovesAllLocalRecords() | ||
| { | ||
| var service = CreateService(); | ||
| service.RecordUpload(1024, "https://utfs.io/f/first", "first.zip"); | ||
| service.RecordUpload(2048, "https://utfs.io/f/second", "second.zip"); | ||
|
|
||
| await service.ClearHistoryAsync(); | ||
|
|
||
| var reloadedService = CreateService(); | ||
| Assert.Empty(await reloadedService.GetUploadHistoryAsync()); | ||
| } | ||
|
coderabbitai[bot] marked this conversation as resolved.
|
||
|
|
||
| private UploadHistoryService CreateService() | ||
| { | ||
| var appConfig = new Mock<IAppConfiguration>(); | ||
| appConfig.Setup(config => config.GetConfiguredDataPath()).Returns(_tempDirectory); | ||
|
|
||
| return new UploadHistoryService( | ||
| Mock.Of<ILogger<UploadHistoryService>>(), | ||
| appConfig.Object); | ||
| } | ||
| } | ||
38 changes: 38 additions & 0 deletions
38
GenHub/GenHub.Tests/GenHub.Tests.Core/Features/Tools/Services/UploadThingServiceTests.cs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,38 @@ | ||
| using GenHub.Features.Tools.Services; | ||
| using Microsoft.Extensions.Logging; | ||
| using Moq; | ||
|
|
||
| namespace GenHub.Tests.Core.Features.Tools.Services; | ||
|
|
||
| /// <summary> | ||
| /// Tests for the disabled UploadThing integration. | ||
| /// </summary> | ||
| public class UploadThingServiceTests | ||
| { | ||
| private readonly UploadThingService _service = | ||
| new(Mock.Of<ILogger<UploadThingService>>()); | ||
|
|
||
| /// <summary> | ||
| /// Verifies that uploads fail closed while short-lived credentials are unavailable. | ||
| /// </summary> | ||
| /// <returns>A task representing the asynchronous test operation.</returns> | ||
| [Fact] | ||
| public async Task UploadFileAsync_WhenCredentialsAreUnavailable_ReturnsNull() | ||
| { | ||
| var result = await _service.UploadFileAsync("unused.zip"); | ||
|
|
||
| Assert.Null(result); | ||
| } | ||
|
|
||
| /// <summary> | ||
| /// Verifies that authenticated deletion also fails closed. | ||
| /// </summary> | ||
| /// <returns>A task representing the asynchronous test operation.</returns> | ||
| [Fact] | ||
| public async Task DeleteFileAsync_WhenCredentialsAreUnavailable_ReturnsFalse() | ||
| { | ||
| var result = await _service.DeleteFileAsync("unused-key"); | ||
|
|
||
| Assert.False(result); | ||
| } | ||
| } |
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
WARNING: Missing parameter validation
The
RemoveHistoryItemAsyncmethod accepts astring urlparameter but doesn't validate that the URL is not null or empty. This could cause issues if called with invalid input.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Keeping this unchanged. The parameter is non-nullable, and the implementation’s equality check safely treats null or empty input as a no-op. The suggested interface change is identical and adds no runtime validation.