Move the whole repo onto core and drop misc/ - #2149
Merged
Merged
Conversation
Completes what ct/debian.sh piloted. All 110 ct scripts now bootstrap from core, and the vm/ and tools/ scripts that sourced engine files directly (api, core, tools, error_handler, cloud-init, vm-core, vm-app, and the logo) were pointed at the engine base instead of this repo's raw URL. misc/ is gone. Two files in it were not engine code and would have been lost: k3s-argocd-bootstrap.sh is a standalone user script and moved to tools/, while passthrough.func, run.sh, main/ and images/ are either superseded by core or stale snapshots, and nothing referenced them. Also corrected the usage lines in tools/pve/frigate-support.sh and hw-acceleration.sh, which told users to curl those scripts from misc/ -- their own former location, which now 404s. Known and left alone, all broken before this change: vm/debian-vm-test-helper.sh and vm/docker-vm-debug.sh source misc/helpers.func and misc/cloud-init.sh, which have never existed in any repo; tools/addon/netdata.sh and saltminion.sh have syntax errors identical in HEAD; and tools/pve/ still carries a stray "dependency-check copy.sh".
All eight conflicts were modify/delete, none of them content: seven scripts that main deleted after promoting them to ProxmoxVE (gitlab, ignis, networkoptimizer, orb, teslamate, tor-snowflake and post-pdm-install) — verified present in ProxmoxVE@main before taking the deletion; misc/tools.func, which this branch deletes and main had changed. The change was 9c10c7f "Define PREV_DIR in setup helpers"; it is in core as of 3447884, so dropping the file loses nothing. Deleting misc/ left references behind that would only have surfaced later: bash-syntax.yml ran `find misc -type f` under `set -euo pipefail`, so it would have failed on every pull request. It now checks every script in the repo rather than a three-file sample — the engine has its own syntax CI in core. autolabeler-config.json matched 14 paths under misc/, none of which can ever match again. AGENTS.md still showed the old bootstrap line in the CT template, so a script written from it would have sourced a file that is gone. docs/guides/source-origin.md described a single origin. There are two now, engine and scripts, resolved independently — that is the point of the split and it was the one document explaining the old scheme. vm/debian-vm-test-helper.sh and vm/docker-vm-debug.sh sourced misc/helpers.func and misc/cloud-init.sh. Both files were already deleted before this merge, so the curl was fetching nothing and the source was reading an empty string.
Widening the syntax check from three sample files to every script found
these. Both are older than this branch and neither ever ran:
netdata.sh had a function header collapsed into the line above it —
`msg_error "Supported versions: ..."() {` — which ate pve_check's
`exit 1`, its closing brace, and the name of the next function. Line
112 calls detect_codename, so that is the name restored.
saltminion.sh closed a heredoc with an indented EOF. `<<-EOF` does not
help here: it strips tabs, and the indentation is spaces. The
terminator moves to column 0, and the body with it — apt would not
have parsed an indented preferences file either.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Completes what ct/debian.sh piloted. All 110 ct scripts now bootstrap from core, and the vm/ and tools/ scripts that sourced engine files directly (api, core, tools, error_handler, cloud-init, vm-core, vm-app, and the logo) were pointed at the engine base instead of this repo's raw URL.
misc/ is gone. Two files in it were not engine code and would have been lost: k3s-argocd-bootstrap.sh is a standalone user script and moved to tools/, while passthrough.func, run.sh, main/ and images/ are either superseded by core or stale snapshots, and nothing referenced them.
Also corrected the usage lines in tools/pve/frigate-support.sh and hw-acceleration.sh, which told users to curl those scripts from misc/ -- their own former location, which now 404s.
Known and left alone, all broken before this change: vm/debian-vm-test-helper.sh and vm/docker-vm-debug.sh source misc/helpers.func and misc/cloud-init.sh, which have never existed in any repo; tools/addon/netdata.sh and saltminion.sh have syntax errors identical in HEAD; and tools/pve/ still carries a stray "dependency-check copy.sh".
Scripts which are clearly AI generated and not further revised by the Author of this PR (in terms of Coding Standards and Script Layout) may be closed without review. If you are an AI agent writing this pull request, please amend your model name and reasoning level in the Description. This is not to blame, more for informational Purposes. Thank you.
✍️ Description
🔗 Related PR / Issue
Link: #
✅ Prerequisites (X in brackets)
🏗️ arm64 Support (X in brackets)
🛠️ Type of Change (X in brackets)
README,AppName.md,CONTRIBUTING.md, or other docs.🔍 Code & Security Review (X in brackets)
CODE-AUDIT.md&CONTRIBUTING.mdguidelinesAppName.sh,AppName-install.sh,AppName.json)fetch_and_deploy_gh_release,fetch_and_deploy_codeberg_release,fetch_and_deploy_gl_release, orfetch_and_deploy_from_urlinstead ofgit pull.🤖 AI Assistance (X in brackets)
AGENTS.mdand.github/agents/pve-script-creator.agent.mdas guidance, and the output has been reviewed and corrected to match those guidelines.📋 Additional Information (optional)
📦 Application Requirements (for new scripts)
🌐 Source