Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed dryrun test in "Test" workflow. #127

Merged
merged 1 commit into from
May 11, 2022
Merged

Conversation

fredericpoitevin
Copy link
Member

@fredericpoitevin fredericpoitevin commented May 11, 2022

Checklist

Verify that your PR checks all the following items.

  • The pull request (PR) has a clear and explanatory title.
  • The description of this PR links to relevant GitHub issues.
  • (N/A) Unit tests have been added in the tests folder:
  • (N/A) The code of this PR is properly documented, with docstrings following simSPI conventions.
  • The PR passes the DeepSource GitHub Actions workflow (refer to comment below).
  • The PR passes Test and Lint GitHub Actions workflows. (refer to comment below)

Description

The dryrun test in the "Test" workflow was initially useful for debugging. But it takes about 2m30s to run and is not useful for anything at this point.

Issue

Addressed #126

@codecov
Copy link

codecov bot commented May 11, 2022

Codecov Report

Merging #127 (853d218) into master (b20c05e) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #127   +/-   ##
=======================================
  Coverage   98.39%   98.39%           
=======================================
  Files          15       15           
  Lines         744      744           
=======================================
  Hits          732      732           
  Misses         12       12           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b20c05e...853d218. Read the comment docs.

@fredericpoitevin fredericpoitevin marked this pull request as ready for review May 11, 2022 23:57
Copy link
Contributor

@ninamiolane ninamiolane left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, thanks!

@ninamiolane ninamiolane merged commit ba8145e into master May 11, 2022
@ninamiolane ninamiolane deleted the remove-dryrun-test branch May 11, 2022 23:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants