-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Luis master #96
Luis master #96
Conversation
…h all supporting files
The function was generating n_particles^2 coordinates due to an additional for loop.
…for completeness.
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
…rrent master branch?
…books/path_config.yaml
Codecov Report
@@ Coverage Diff @@
## master #96 +/- ##
==========================================
+ Coverage 98.12% 98.39% +0.27%
==========================================
Files 15 15
Lines 744 744
==========================================
+ Hits 730 732 +2
+ Misses 14 12 -2
Continue to review full report at Codecov.
|
View / edit / reply to this conversation on ReviewNB geoffwoollard commented on 2022-04-06T15:14:05Z "In order to run the tests, it is also necessary to have installed the TEM-simulator" --> Modify text to reflect containerization. |
View / edit / reply to this conversation on ReviewNB geoffwoollard commented on 2022-04-06T15:14:06Z Is there any docs in the TEM simulator on what convention is used? It would be really good to show how these angles are applied in the projection. In case this is out of scope for this PR, I have created an issue here: https://github.com//issues/97
|
View / edit / reply to this conversation on ReviewNB geoffwoollard commented on 2022-04-06T15:14:07Z Could there be a bit more explanation of why these settings give a "perfect" micrograph? Is it one or more of the settings below? If there is no defocus, and the cs is zero then the CTF should be sin(0), no? Or is there some amplitude contrast that contributes a cos(0) = 1 part, making the CTF = Asin(0) + Bcos(0) = B?
I don't see any thing for A and B or some ratio of them (amplitude contrast) in the settings.
See Eq 1 in the CTFFIND4 (2015) paper for ref: 10.1016/j.jsb.2015.08.008
|
View / edit / reply to this conversation on ReviewNB geoffwoollard commented on 2022-04-06T15:14:08Z interesting circular artefact in the middle panel... perhaps it's from one of the aperture settings in the TEM simulator. |
View / edit / reply to this conversation on ReviewNB geoffwoollard commented on 2022-04-06T15:14:08Z Very nice and clear example! Great work! |
Closes #57 since it is essentially the same with some fixes. |
I opened #98 to address the fact that the "Building simSPI Container" check is skipped. |
Copy of #57 on main fork, for test.