Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove filing history description - to be merged on 13th December 2016 #68

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

nshumoogum
Copy link

Description has been deprecated, instead use proposed-transfer-societas-europaea-from-uk enum.

Description has been deprecated, instead use `proposed-transfer-societas-europaea-from-uk` enum.
Copy link
Contributor

@macreman macreman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 to merge on 13th December 2016 then PR into master on same day

@CountCulture
Copy link

This looks like removal, not deprecation.
I would suggest removal should only be for upstream user, not downstream.

If downstream users are going to include these mappings in their systems there needs to be stability in the keys, as they may well have to deal with legacy data (for example if they store the keys in their systems, and map to the values at run time). Changing or removing the keys is therefore problematic, although there's no reason why it can't be enforced upstream.

@nshumoogum
Copy link
Author

@CountCulture Thank you for your comment. Removal of proposed-transfer-societas-europaea-to-uk will take place in April as we need to give between 3 to 6 months notice of breaking changes for client applications. We have released a message on our developer forum regarding these changes and we plan to release an Enumerations API which will remove the need to hardcode enumeration descriptions within client applications in the future, for more information see our developer forum, updated filing history descriptions.

Base automatically changed from develop to master June 11, 2021 08:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants