simplestore: mark expired orders canceled, not paid#767
Open
karamble wants to merge 1 commit into
Open
Conversation
invoiceExpired was a copy of invoiceSettled and set order.Status to StatusPaid for an order whose invoice expired without payment, so an unpaid expired order was indistinguishable from a real sale and any StatusChanged consumer keying on StatusPaid saw a false payment. Set StatusCanceled instead and fix the copied comment.
dajohi
approved these changes
Jun 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
simplestore.invoiceExpired() is a near-verbatim copy of invoiceSettled() and set order.Status = StatusPaid for an order whose invoice expired without payment, so an unpaid expired order was indistinguishable from a real sale and any StatusChanged consumer keying on StatusPaid saw a false payment.
This sets the existing (previously unused) StatusCanceled instead, and fixes the copied "// Mark order as paid." comment. invoiceExpired already correctly skips the digital-file send loop and notifies the buyer the order expired, so only the status assignment changes.
Closes #766