client: accept GC re-invites for an existing local GC#771
Open
karamble wants to merge 1 commit into
Open
Conversation
handleGCInvite rejected any RMGroupInvite for a GC that already exists locally, storing nothing and firing no notification, so a stale local GC copy (e.g. after restoring an old backup) could never be recovered: the admin re-adds the user by re-inviting, but the invite was always dropped. Store the invite and notify even when the GC exists. The stale roster is refreshed by the normal RMGroupList update (maybeUpdateGC) once the invite is accepted, which already verifies the sender's admin permission and rejects generation backtracks.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
handleGCInvite rejected any RMGroupInvite for a GC that already exists locally, storing nothing and firing no notification, so a stale local GC copy (e.g. after restoring an old backup) could never be recovered. This stores the invite and notifies even when the GC exists; the stale roster is refreshed by the normal RMGroupList update (maybeUpdateGC) once the invite is accepted, which already verifies the senders admin permission and rejects generation backtracks.
Passes the existing client GC e2e suite (internal/e2etests/gc_test.go).
Closes #770