client: don't fail GC part/kill when the GC has unKXd members#773
Open
karamble wants to merge 1 commit into
Open
client: don't fail GC part/kill when the GC has unKXd members#773karamble wants to merge 1 commit into
karamble wants to merge 1 commit into
Conversation
PartFromGC and KillGroupChat delete the GC inside their db transaction and then call sendToGCMembers to notify the pre-delete member list. When the GC has unKXd members, sendToGCMembers re-reads the GC to find the owner to mediate transitive KX through, but the GC is already gone, so GetGC returns ErrNotFound and the whole part/kill errors out even though it succeeded. Tolerate the GC being gone: stop setting up mediate-ID requests (the message was already sent to the KX'd members) instead of returning the error. Adds a regression test (TestGCPartWithUnkxdMember) that fails without the fix.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PartFromGC and KillGroupChat delete the GC inside their db transaction and then call sendToGCMembers to notify the pre-delete member list. When the GC has unKXd members, sendToGCMembers re-reads the GC to find the owner to mediate transitive KX through, but the GC is already gone, so GetGC returns ErrNotFound and the whole part/kill errors out even though it succeeded. Tolerate the GC being gone: stop setting up mediate-ID requests (the message was already sent to the KXd members) instead of returning the error.
Includes a regression test (TestGCPartWithUnkxdMember) that fails without the fix; the full client GC e2e suite passes.
Closes #772