Add type info interfaces motivated by numba #534
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add `IsSameType` used for matching arg types between numba inferred signatures and CppOverloads in cppyy. - Add type info reflection interfaces for integer, void pointer, signed and unsigned types. - Also added interfaces `IsIntegral` and `IsFloating` that check if types have the respective representations. Used in the case of Numba where scoring based on reflection is required.
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
| @@ -1573,8 +1609,17 @@ namespace Cpp { | |||
| return QT.getNonReferenceType().getAsOpaquePtr(); | |||
| } | |||
|
|
|||
| TCppType_t GetUnqualifiedType(TCppType_t type) { | |||
| if (!type) | |||
| return 0; | |||
There was a problem hiding this comment.
warning: use nullptr [modernize-use-nullptr]
Suggested change
| return 0; | |
| return nullptr; |
| TCppType_t GetUnderlyingType(TCppType_t type) | ||
| { | ||
| if (!type) | ||
| return 0; |
There was a problem hiding this comment.
warning: use nullptr [modernize-use-nullptr]
Suggested change
| return 0; | |
| return nullptr; |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #534 +/- ##
==========================================
- Coverage 72.71% 72.16% -0.56%
==========================================
Files 9 9
Lines 3618 3647 +29
==========================================
+ Hits 2631 2632 +1
- Misses 987 1015 +28
🚀 New features to boost your workflow:
|
|
We should add tests. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
IsSameTypeused for matching arg types between numba inferred signatures and CppOverloads in cppyy.IsIntegralandIsFloatingthat check if types have the respective representations. Used in the case of Numba where scoring based on reflection is required.will add tests