perf(runtime): drain due timers with extract_if instead of split_off - #1072
Merged
Merged
Conversation
Despite both extract_if and split_off being O(log N) on the number of active timers, split_off is a much heavier operation that performs a number of allocations before even starting the search. It creates a measurable cost per ticks on the scale of thousands of running timers. extract_if is just one O(log N) search for the smallest key, then O(1) sibling walk on the tree. AI disclaimer: AI was used to pin down the cost increase with running timers, analyzed split_off implementation and suggested the use of extract_if instead.
github-actions
Bot
added
package: runtime
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Despite both extract_if and split_off being O(log N) on the number of active timers, split_off is a much heavier operation that performs a number of allocations before even starting the search. It creates a measurable cost per ticks on the scale of thousands of running timers.
extract_if is just one O(log N) search for the smallest key, then O(1) sibling walk on the tree.
AI disclaimer: AI was used to pin down the cost increase with running timers, analyzed split_off implementation and suggested the use of extract_if instead.