feat(buf): add support for memmap2#684
Merged
Berrysoft merged 2 commits intocompio-rs:masterfrom Feb 14, 2026
Merged
Conversation
George-Miao
added
enhancement
Berrysoft
reviewed
Feb 13, 2026
Contributor
There was a problem hiding this comment.
Pull request overview
This pull request adds support for the memmap2 library to compio-buf by implementing the necessary buffer traits (IoBuf, IoBufMut, and SetLen) for memory-mapped types.
Changes:
- Added memmap2 as an optional dependency with a corresponding feature flag
- Implemented IoBuf trait for both memmap2::Mmap and memmap2::MmapMut
- Implemented IoBufMut and SetLen traits for memmap2::MmapMut
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| compio-buf/Cargo.toml | Added memmap2 0.9.9 as an optional dependency and created corresponding feature flag |
| compio-buf/src/lib.rs | Added conditional re-export of memmap2 crate when feature is enabled |
| compio-buf/src/io_buf.rs | Implemented IoBuf, IoBufMut, and SetLen traits for memmap2 types to enable use as IO buffers |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
George-Miao
force-pushed
the
feat/buf/memmap2
branch
from
4366971 to
2cb0b8e
Compare
George-Miao
force-pushed
the
feat/buf/memmap2
branch
from
2cb0b8e to
a683e32
Compare
Berrysoft
approved these changes
Feb 14, 2026
Open
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.